Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gas charges in VM #649

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Update gas charges in VM #649

merged 3 commits into from
Aug 25, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • When I had made a pass through the VM before the gas charges were not finalized. Now they are and with the test vector runner I compared almost everything is matching except for some code path differences (and common things like puppet and chaos actor not being registered yet)

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell added VM Interop Interop with Lotus/specs-actors and testing labels Aug 25, 2020
@austinabell austinabell merged commit 3fe1d46 into main Aug 25, 2020
@austinabell austinabell deleted the austin/vm/gasupd branch August 25, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
Interop Interop with Lotus/specs-actors and testing VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinabell @ec2 @dutterbutter