Space race genesis and bootnodes updates #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
requested review from
StaticallyTypedAnxiety,
flodesi,
RajarupanSampanthan and
timvermeulen
forest/src/daemon.rs
Outdated
| .await | ||
| .unwrap(); | ||
| let beacon = DrandBeacon::new( | ||
| "https://api.drand.sh", |
There was a problem hiding this comment.
This is used in 2 places might be better to make it a constant
There was a problem hiding this comment.
yeah I'll do that, was just being lazy since the one is just used for tests that are ignored by default
RajarupanSampanthan
approved these changes
Aug 26, 2020
dutterbutter
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Seems kademlia is not bootstrapping as it should, and sync is not initializing as it was before, but I'm just doing minimum changes to fix #648 and setup a functional node
Reference issue to close (if applicable)
Closes #648
Other information and links