Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Chaos Actor #653

Merged
merged 16 commits into from
Aug 26, 2020
Merged

Adding Chaos Actor #653

merged 16 commits into from
Aug 26, 2020

Conversation

RajarupanSampanthan
Copy link
Contributor

@RajarupanSampanthan RajarupanSampanthan commented Aug 26, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Adds the Chaos Actor
  • Just one little change regarding cid.UNDEF and address.UNDEF needs to be made before its ready for review

Reference issue to close (if applicable)

Closes
#640

Other information and links

austinabell
austinabell reviewed Aug 26, 2020
View reviewed changes
vm/actor/src/builtin/chaos/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/chaos/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/chaos/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/singletons.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/chaos/state.rs Outdated Show resolved Hide resolved
austinabell
austinabell suggested changes Aug 26, 2020
View reviewed changes
utils/bigint/Cargo.toml Outdated Show resolved Hide resolved
vm/actor/src/builtin/chaos/mod.rs Outdated Show resolved Hide resolved
austinabell
austinabell reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the two small comments!

vm/actor/src/util/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/util/unmarshallable.rs Outdated Show resolved Hide resolved
@RajarupanSampanthan RajarupanSampanthan marked this pull request as ready for review August 26, 2020 16:16
austinabell
austinabell approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, update those nits I commented or don't, doesn't matter much

vm/actor/Cargo.toml Outdated Show resolved Hide resolved
vm/actor/src/util/chaos/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/util/unmarshallable.rs Outdated Show resolved Hide resolved
@RajarupanSampanthan RajarupanSampanthan merged commit fd91198 into main Aug 26, 2020
@RajarupanSampanthan RajarupanSampanthan deleted the rupan/chaos branch August 26, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Status: Needs Review VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RajarupanSampanthan @ec2 @austinabell