Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registering of Actors to the VM #654

Merged
merged 15 commits into from
Aug 27, 2020
Merged

Allow registering of Actors to the VM #654

merged 15 commits into from
Aug 27, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Aug 26, 2020

Summary of changes
Changes introduced in this pull request:

  • Updates conformance tests to register puppet and chaos actor for testing
  • Adds custom actors registration to the VM

Reference issue to close (if applicable)

Closes
#646

Other information and links

Blocked by
#640

austinabell
austinabell reviewed Aug 26, 2020
View reviewed changes
tests/conformance_tests/tests/conformance_runner.rs Outdated Show resolved Hide resolved
tests/conformance_tests/tests/conformance_runner.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/codes.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_runtime.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_runtime.rs Show resolved Hide resolved
@ec2 ec2 requested a review from austinabell August 26, 2020 20:23
@ec2 ec2 merged commit 809e3e8 into main Aug 27, 2020
@ec2 ec2 deleted the ec2/actor-register branch August 27, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@RajarupanSampanthan RajarupanSampanthan RajarupanSampanthan approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@flodesi flodesi Awaiting requested review from flodesi

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
Status: Needs Review VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ec2 @RajarupanSampanthan @austinabell