Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose message fields #655

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Expose message fields #655

merged 3 commits into from
Aug 27, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Aug 26, 2020

Summary of changes
Changes introduced in this pull request:

  • The only reason to have kept from being public was for if the Cid was to be cached later, but doesn't really seem like much of a reason to keep. I didn't remove the pattern altogether for backwards compatibility and for convenience in certain places (just testing things)
    • Avoids runtime checks for these commonly used funcs so kinda a micro optimization lol

Main reason is just because rust-analyzer is borked and gives errors on builder patterns

Reference issue to close (if applicable)

Closes

Other information and links

@ec2
Copy link
Member

ec2 commented Aug 27, 2020

I think the folks at Zondax use our Message library. Should probably tag them here. Not sure who to tag though.

@austinabell
Copy link
Contributor Author

I think the folks at Zondax use our Message library. Should probably tag them here. Not sure who to tag though.

It's not a breaking change but @jleni. I will bump the patch version and release this

@austinabell austinabell merged commit aa6167c into main Aug 27, 2020
@austinabell austinabell deleted the austin/exposemsg branch August 27, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants