Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime transaction logic #666

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Update runtime transaction logic #666

merged 3 commits into from
Aug 31, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Aug 28, 2020

Summary of changes
Changes introduced in this pull request:

  • So the issue here is that the potential errors were not exiting the code as they happened and if an error happened in the transaction, it would still update the state before returning. Since the go impl just panics on the spot and recovers, this needs to be like this to be able to match.

Sorry for the conflicts @timvermeulen

Reference issue to close (if applicable)

Closes

Other information and links

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timvermeulen you might wanna take a look and pull in these changes. Lots of linting changed in the miner actor. Could have some merge conflicts maybe?

LGTM

@austinabell austinabell merged commit cd68b53 into main Aug 31, 2020
@austinabell austinabell deleted the austin/actortx branch August 31, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants