Update statetree cache #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
reviewed
Aug 31, 2020
austinabell
reviewed
Aug 31, 2020
ec2
reviewed
Sep 1, 2020
austinabell
suggested changes
Sep 3, 2020
There was a problem hiding this comment.
oh man, that error handling is pretty painful now. Looking at this I didn't realize basically all state tree access errors are explicitly fatal (defeating purpose of the Box<dyn std::error::Error>). I can try to review if there is an edge case where an error would be downcasted and made non-fatal if encoding error on go impl
austinabell
reviewed
Sep 4, 2020
ec2
approved these changes
Sep 4, 2020
austinabell
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #373
Other information and links