Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage miner integration #670

Merged
merged 57 commits into from
Sep 25, 2020
Merged

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

@StaticallyTypedAnxiety StaticallyTypedAnxiety commented Aug 31, 2020

Summary of changes
Changes introduced in this pull request:

  • Adds websockets support and implements missing functions

Reference issue to close (if applicable)

Closes #629
Closes #630
Closes #631
Closes #632

Other information and links

blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Show resolved Hide resolved
forest/src/daemon.rs Outdated Show resolved Hide resolved
node/rpc/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/lib.rs Outdated Show resolved Hide resolved
@ec2
Copy link
Member

ec2 commented Sep 2, 2020

Gunna go much more in depth tomorrow. My cloud lotus node is currently syncing.
Could you also show what commands you run to do some of the testing? What I do to lotus nodes is

  1. Run wscat -c 127.0.0.1:1234/rpc/v0
  2. Send requests like: {"jsonrpc":"2.0","method":"Filecoin.ChainNotify","params":[],"id":1}

@StaticallyTypedAnxiety
Copy link
Contributor Author

Gunna go much more in depth tomorrow. My cloud lotus node is currently syncing.
Could you also show what commands you run to do some of the testing? What I do to lotus nodes is

1. Run `wscat -c 127.0.0.1:1234/rpc/v0`

2. Send requests like:` {"jsonrpc":"2.0","method":"Filecoin.ChainNotify","params":[],"id":1}`

I would use the same commands :)

@austinabell
Copy link
Contributor

You committed the grpc protobuf submodule by the way (and I assume unintended)

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do believe that only the variables that need to be mutated across threads in the chain store should be wrapped in a mutex, you are adding locks around a lot of logic that doesn't need it and performance and/or deadlocks might be a problem

blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
forest/src/daemon.rs Outdated Show resolved Hide resolved
node/rpc/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/lib.rs Show resolved Hide resolved
node/rpc/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/state_api.rs Outdated Show resolved Hide resolved
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @ec2's checks

blockchain/chain/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot the hit approve lgtm

Co-authored-by: Austin Abell <austinabell8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants