Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edge cases for dynamic error handling in VM #671

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • If there was a read or write that ran out of gas, the error would not be downcasted correctly, as it was just checking for encoding errors. To be safe, all downcasts are updated to use the one attached to ActorError where both EncodingError and ActorError can be downcasted from a dynamic error.
  • Updates test runner to only skip invalid files now that all others are passing (and prints passes instead of failures)

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 26517fb into main Aug 31, 2020
@austinabell austinabell deleted the austin/vm/dynerrhandle branch August 31, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants