Runtime trait and vm types #68
Conversation
austinabell
commented
Dec 4, 2019
austinabell
commented
- Implements Set up runtime framework #65 which sets up the trait to be used by the interpreter and functions and stubs out some types some of which being incompatible for us
- Also implements other needed types needed within the VM
austinabell
requested review from
ec2,
ansermino,
GregTheGreek and
dutterbutter
There was a problem hiding this comment.
So theres a few spots where you have types stubbed out as () (or other), i think it would be most beneficial to create a bunch of fake types at the top of runtime/mod.rs that defines the type as an empty struct (if it applies). That way it can act as a checklist later on as we further implement this
| } | ||
| /// returns true if exited with an error code | ||
| pub fn is_error(&self) -> bool { | ||
| !self.success |
There was a problem hiding this comment.
lol i love this function and is_success
There was a problem hiding this comment.
And allows_state_updates haha.
What is the diff between is_success and allows_state_updates
There was a problem hiding this comment.
following spec for now :P and to future proof is we use more complex types in the future
There was a problem hiding this comment.
allow_state_updates will be kept just as a future proof for if a call has static context or something, not sure exactly why it exists in Filecoin spec
