Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipset vector runner #682

Merged
merged 21 commits into from
Sep 3, 2020
Merged

Tipset vector runner #682

merged 21 commits into from
Sep 3, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Sep 2, 2020

Summary of changes
Changes introduced in this pull request:

  • Updates test runner framework for tipset vectors
    • Also refactors so all code isn't in a monolithic file and can be more easily navigated/built upon and dependencies correctly optionally compiled
  • The only tipset vector fails because blocked on miner actor impl as mentioned, but seems like that is only discrepancy, so should be fine to pull in and if any other difference it can be debugged after

Reference issue to close (if applicable)

Closes #680

Other information and links

@austinabell austinabell changed the base branch from main to austin/applyblocksrefactor September 2, 2020 16:32
@austinabell
Copy link
Contributor Author

currently blocked by #559. All transactions pass and return the correct exit code, but the reward transaction fails because the miner state has changed (and too breaking to just update for this) and burns the funds instead.

Base automatically changed from austin/applyblocksrefactor to main September 3, 2020 13:10
@austinabell austinabell added Interop Interop with Lotus/specs-actors and testing Status: Needs Review labels Sep 3, 2020
@@ -94,6 +94,22 @@ impl Actor {

rt.create_actor(actor_cid, &actor_address)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add comment please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just used for testing, but done

@austinabell austinabell merged commit 0db7ddb into main Sep 3, 2020
@austinabell austinabell deleted the austin/tipsetvectors branch September 3, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tipset test vector runner
3 participants