Initial Structures for Message - Manager Communication #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added chain info struct and new fn
* Added container for decoding pubsub messages * Created new fn for container creation * Added BlockProposer trait
dutterbutter
requested review from
austinabell,
ansermino,
ec2 and
GregTheGreek
austinabell
suggested changes
Dec 5, 2019
ansermino
reviewed
Dec 5, 2019
* Renamed chain_info --> block_msg * Corrected export of mod * Removed String in favor for Display * Prefixed dead code with underscore to avoid compiler errors
austinabell
reviewed
Dec 5, 2019
austinabell
reviewed
Dec 5, 2019
austinabell
approved these changes
Dec 6, 2019
ansermino
reviewed
Dec 7, 2019
BlockMsg in go-filecoin (chaininfo). Moved into chain_sync |
* Restructured blockmsg to live under chain_sync * Added go-filecoin reference to BlockMsg comment
|
@GregTheGreek @ec2 ping |
GregTheGreek
approved these changes
Dec 9, 2019
ec2
approved these changes
Dec 9, 2019
vmx
pushed a commit
to dignifiedquire/forest
that referenced
this pull request
Mar 19, 2020
…Safe#69) * feat(cache): generate_post and seal both accept cache dir-path * refactor(trait): remove unused constraints * feat(crate): upgrade to new API * ci(key): cache key should include arch * feat(cache): generate_post and seal both accept cache dir-path * feat(builder): force caller to provide sector cache path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR but steps towards setting up the necessary structures for receiving and proposing block data from libp2p. Specifically, this PR contains a struct used to place pubsub message data to be sent to the manager for validation and the
BlockProposertrait withsend_gossip_block,send_own_block,send_helloto be used for communication between receiving/adding blocks and theChainManager. For background, the manager in the context of the PR deals with incoming blocks and semantic validation as per the spec and go implementation.Below is further detail and context of the discussion I had with @ec2 and my interpretation of how go-filecoin handles incoming/outgoing data as it related to the
ChainManager.For
SendGossipBlock:See ProcessBlock for additional details.
Upon receiving a
pubsub messageto process a block for inclusion into the chain, the data contained within thepubsub messageis decoded, expanded on and placed in a struct for validation prior to propagation.The pubsub message should contain the following fields:
Source peerIdSender peerIdBlock Datain bytesFrom Block Data you can derive the
head tipset keys(CIDS), andheight. These fields are placed insideBlockMsgstruct (as per PR), to be sent to the manager for semantic validation.For
SendOwnBlock:See AddNewBlock for additional details.
While publishing a new block on the block topic, the fields required for validation are derived from the block and node and are placed in the
BlockMsgstruct to be sent to the manager for semantic validation.