Update Miner actor #691

timvermeulen · 2020-09-08T21:25:12Z

Closes #559

commit 8ef5ae5 Author: Austin Abell <austinabell8@gmail.com> Date: Wed Sep 16 12:30:01 2020 -0400 Peer stats tracking and selection (#701) * Added peer manager logic and started to move blocksync handling into network context * Migrate to using handled blocksync requests and remove a duplicate code * Fix test use * Fix duration subtract logic * Update peer manager updates from hello requests * Docs and cleanup * more cleanup commit dc0ff4c Author: Eric Tu <6364934+ec2@users.noreply.github.com> Date: Tue Sep 15 14:43:18 2020 -0400 Semantic Validation for Messages (#703) * semantic validation * suggestions * suggestions commit 3411459 Author: Austin Abell <austinabell8@gmail.com> Date: Mon Sep 14 15:14:48 2020 -0400 ChainSync refactor (#693) * Switch chain store to threadsafe * Update genesis to arc reference * wip refactoring chain sync to workers in async tasks * Update network event handling and remove NetworkHandler * Update tipset scheduling logic * Update peer retrieval to take a random sample of available peers * Cleanup and enabling all existing tests * fix worker task spawn * Add TODO for emit event ignoring and change to error log * oops * Update comment * Fix typo commit 66ca99e Author: Eric Tu <6364934+ec2@users.noreply.github.com> Date: Mon Sep 14 13:48:22 2020 -0400 Fix StateManager use in different components (#694) * wrap sm in arc * lint * fix tests * suggestions * clippy commit 96b64cb Author: nannick <rajarupans@gmail.com> Date: Mon Sep 14 10:33:27 2020 -0400 Drand ignore env variable (#697) * First commit * Using enviromental vairable instead of cli flag * FIxing dumb mistakes * Renaming drand flag * UPdate latest_beacon_entry * Adding drand check * Adding doc commit 548a464 Author: Austin Abell <austinabell8@gmail.com> Date: Thu Sep 10 13:22:22 2020 -0400 Print out conformance results and add log for skips (#695) commit 0d7b16c Author: Stepan <s.s.naumov@gmail.com> Date: Tue Sep 8 09:01:05 2020 -0400 Add CLI command to add Genesis Miner to Genesis Template (#644) * AddMinerGenesis cmd command * fixing tests * addressing comments * removing jsons

# Conflicts: # blockchain/chain_sync/src/sync_worker.rs

# Conflicts: # blockchain/chain_sync/src/sync_worker.rs # blockchain/state_manager/src/utils.rs # node/rpc/src/state_api.rs

vm/actor/src/builtin/miner/miner_state.rs

austinabell

Going to break this one up because I need to take a break and there are some common issues

vm/actor/src/builtin/miner/mod.rs

austinabell · 2020-09-24T19:09:34Z

vm/actor/src/builtin/miner/mod.rs

+        let empty_deadline_cid = rt
+            .store()
+            .put(&Deadline::new(empty_array.clone()), Blake2b256)
+            .unwrap();


These should not be unwrapped, they could hit an out of gas error, which should not crash

austinabell · 2020-09-24T19:09:40Z

vm/actor/src/builtin/miner/mod.rs

+        let empty_deadlines_cid = rt
+            .store()
+            .put(&Deadlines::new(empty_deadline_cid), Blake2b256)
+            .unwrap();


austinabell · 2020-09-24T19:09:48Z

vm/actor/src/builtin/miner/mod.rs

+            .put(&Deadlines::new(empty_deadline_cid), Blake2b256)
+            .unwrap();
+
+        let empty_vesting_funds_cid = rt.store().put(&VestingFunds::new(), Blake2b256).unwrap();


vm/actor/src/builtin/miner/mod.rs

vm/actor/src/builtin/miner/types.rs

vm/actor/src/builtin/miner/mod.rs

…adline} and State::save_deadlines

vm/actor/src/builtin/miner/mod.rs

types/src/sector/mod.rs

vm/actor/src/builtin/miner/monies.rs

vm/actor/src/builtin/miner/partition_state.rs

vm/actor/src/builtin/miner/policy.rs

vm/actor/src/builtin/miner/sector_map.rs

vm/actor/src/builtin/miner/sectors.rs

vm/actor/src/builtin/power/mod.rs

vm/actor/src/builtin/power/types.rs

austinabell · 2020-09-26T12:06:27Z

vm/actor/src/builtin/miner/mod.rs

+        let empty_bitfield_cid = rt.store().put(&BitField::new(), Blake2b256).unwrap();
+
+        let empty_deadline_cid = rt
+            .store()
+            .put(&Deadline::new(empty_array.clone()), Blake2b256)
+            .unwrap();
+
+        let empty_deadlines_cid = rt
+            .store()
+            .put(&Deadlines::new(empty_deadline_cid), Blake2b256)
+            .unwrap();
+
+        let empty_vesting_funds_cid = rt.store().put(&VestingFunds::new(), Blake2b256).unwrap();


These errors are still not downcasted, and no reason not too, since a direct interaction with the store. It's okay for the error to be incorrect until I make another pass, but I'd really like to avoid a potential crash when using.

Can probably downcast all of these errors at once if you put this logic in a smaller scope

WIP

5ca83ba

timvermeulen added Status: DO NOT MERGE VM labels Sep 8, 2020

timvermeulen added 10 commits September 14, 2020 20:38

More changes

9bde0d8

Even more changes

0178e18

Amt docs

ddcd297

Clippy & copyright

14f9ff6

Delete old deadline tests

32af575

Fix verify_block_signature

f046efb

Fix state_api

cbb0a5e

Merge branch 'main' into tim/miner_actor

9b6c254

# Conflicts: # blockchain/chain_sync/src/sync_worker.rs

Silent unused variable warnings

a2adcc1

timvermeulen marked this pull request as ready for review September 21, 2020 14:56

timvermeulen requested review from ansermino, austinabell, dutterbutter and ec2 as code owners September 21, 2020 14:56

timvermeulen added 3 commits September 21, 2020 17:06

clippy

17d89ec

clippy

26831a8

clippy

8b73d5d

timvermeulen added Status: Needs Review and removed Status: DO NOT MERGE labels Sep 21, 2020

austinabell added 6 commits September 21, 2020 14:35

Fix miner worker addr function

fb09242

fix load_sectors_from_set

842ba78

Fix get_miner_info

7d596a5

miner faults update

985cc31

Setup faults and recoveries logic

8d830fa

Add todo for checking verification function

86bd526

austinabell mentioned this pull request Sep 22, 2020

Update winning post proof validation #712

Closed

timvermeulen added 3 commits September 24, 2020 20:10

Use return value

b31b895

Rename file

d11ede9

Merge branch 'main' into tim/miner_actor

0085025

# Conflicts: # blockchain/chain_sync/src/sync_worker.rs # blockchain/state_manager/src/utils.rs # node/rpc/src/state_api.rs

austinabell reviewed Sep 24, 2020

View reviewed changes

austinabell suggested changes Sep 24, 2020

View reviewed changes

timvermeulen added 2 commits September 25, 2020 11:56

More PR fixes

c30e5c7

Add assertions and error message

5be85ea

austinabell reviewed Sep 25, 2020

View reviewed changes

vm/actor/src/builtin/miner/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Show resolved Hide resolved

austinabell reviewed Sep 25, 2020

View reviewed changes

vm/actor/src/builtin/miner/mod.rs Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Show resolved Hide resolved

timvermeulen added 2 commits September 25, 2020 16:35

Downcast errors originating from Deadlines::{load_deadline, update_de…

b7a713c

…adline} and State::save_deadlines

Rename Sectors::{new, load} to Sectors::{load, load_sector}

9e00740

austinabell reviewed Sep 25, 2020

View reviewed changes

Merge branch 'main' into tim/miner_actor

1e2a564

austinabell reviewed Sep 25, 2020

View reviewed changes

Fix inverted logic

838d8a9

austinabell reviewed Sep 25, 2020

View reviewed changes

vm/actor/src/builtin/miner/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/mod.rs Outdated Show resolved Hide resolved

austinabell reviewed Sep 25, 2020

View reviewed changes

types/src/sector/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/monies.rs Outdated Show resolved Hide resolved

timvermeulen added 3 commits September 25, 2020 19:06

Fix state manager

9a0501a

Remove unused parameters

550185d

clippy

526f84e

austinabell reviewed Sep 25, 2020

View reviewed changes

vm/actor/src/builtin/miner/partition_state.rs Show resolved Hide resolved

vm/actor/src/builtin/miner/policy.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/policy.rs Outdated Show resolved Hide resolved

Replace function by const, remove duplication, remove comment

376e026

austinabell suggested changes Sep 25, 2020

View reviewed changes

vm/actor/src/builtin/miner/sector_map.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/miner/sectors.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/power/mod.rs Outdated Show resolved Hide resolved

vm/actor/src/builtin/power/types.rs Show resolved Hide resolved

Rename field, fix macro formatting, remove unnecessary vec

faf8367

austinabell reviewed Sep 26, 2020

View reviewed changes

Downcast errors

24296ef

austinabell approved these changes Sep 26, 2020

View reviewed changes

Merge branch 'main' into tim/miner_actor

216d574

timvermeulen merged commit f007210 into main Sep 26, 2020

timvermeulen deleted the tim/miner_actor branch September 26, 2020 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Miner actor #691

Update Miner actor #691

timvermeulen commented Sep 8, 2020

austinabell left a comment

austinabell Sep 24, 2020

austinabell Sep 24, 2020

austinabell Sep 24, 2020

austinabell Sep 26, 2020

Update Miner actor #691

Update Miner actor #691

Conversation

timvermeulen commented Sep 8, 2020

austinabell left a comment

Choose a reason for hiding this comment

austinabell Sep 24, 2020

Choose a reason for hiding this comment

austinabell Sep 24, 2020

Choose a reason for hiding this comment

austinabell Sep 24, 2020

Choose a reason for hiding this comment

austinabell Sep 26, 2020

Choose a reason for hiding this comment