Updating Chaos Actor and Test Vectors #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orest into rupan/test_and_chaos
RajarupanSampanthan
requested review from
austinabell,
ec2 and
dutterbutter
and removed request for
ec2
austinabell
reviewed
Sep 11, 2020
austinabell
reviewed
Sep 11, 2020
Remove print statement
…o transition. 70/80 tests passing
austinabell
suggested changes
Oct 5, 2020
austinabell
reviewed
Oct 5, 2020
…orest into rupan/test_and_chaos
austinabell
added
Status: Needs Changes
VM
Status: Needs Review
and removed
Status: Needs Changes
labels
austinabell
reviewed
Oct 6, 2020
vm/actor/src/util/chaos/types.rs
Outdated
|
|
||
| /// CreateActorArgs are the arguments to CreateActor. | ||
| #[derive(Serialize_tuple, Deserialize_tuple)] | ||
| #[serde(rename_all = "PascalCase")] |
There was a problem hiding this comment.
Can you remove all of these? They don't get used when serializing a tuple
austinabell
approved these changes
Oct 7, 2020
dutterbutter
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
#689
Other information and links