Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make block validations async #702

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Make block validations async #702

merged 3 commits into from
Sep 18, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Each block validation check was being done async, but each block validation was done synchronously. Just some setup toward Add Block Validation Check Methods #78 and will be much more efficient.

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit d4dee5a into main Sep 18, 2020
@austinabell austinabell deleted the austin/block/validations branch September 18, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
Enhancement Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinabell @ec2 @dutterbutter