-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update block validations #711
Conversation
I noticed in Lotus that the whether the block has been validated or not only effects whether the signature of the block is checked again or not. It looks like everything else gets checked again. Any thoughts on if this is desired? |
You're mixing up the block header signature verification cache with the block validation. We don't cache the validated status of the signature check, but that's why the |
Summary of changes
Changes introduced in this pull request:
ElectionProof
to blocks crate as logic was not tied to crypto functions and want to keep crypto crate as small as possibleWhat left unfinished (I will create issues for):
verify_winning_post_proof
: there is conflicts with miner actor PR, and the changes should be focused on in their own changes as it's very specific integration with proofsReference issue to close (if applicable)
Closes #78
Other information and links