-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redundant writes to Hamt and Amt to interop #731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
added
Status: Needs Review
Interop
Interop with Lotus/specs-actors and testing
labels
Oct 6, 2020
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
October 6, 2020 22:00
austinabell
requested review from
StaticallyTypedAnxiety,
RajarupanSampanthan and
timvermeulen
October 6, 2020 22:05
ec2
approved these changes
Oct 8, 2020
timvermeulen
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Edit: I changed this to only use the feature in
actors
. I thought about it more and the only time the redundant writes is needed is within the VM execution (and excluding state tree reads/writes since those aren't charged) so this barrier can safely be set here I am almost certain.The reason this will not cause any issues is because the feature changes what the (H)amt will functionally do and what is persisted, but the data will be the same and the root Cid will always match. The benefit to doing this way is we don't have to deal with the performance regression outside of VM where the blockstore reads/writes diff cannot cause a consensus issue.
Reference issue to close (if applicable)
Closes #729
Other information and links