Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base fee in conformance, bump versions and cleanup #739

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 9, 2020

Summary of changes
Changes introduced in this pull request:

  • Another discrepancy in the test-vector update, base fee wasn't being used if included in vector
  • bumps test vectors version (wanted to debug with more recent, but didn't include the randomness change)
  • Organize skips to be more readable

442/589 tests total are passing, but the overlap with skips brings it down lower, but seems like all failures are related

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 891cd3c into main Oct 9, 2020
@austinabell austinabell deleted the austin/fixconformance branch October 9, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants