Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miner constructor params and proving period offset calculation #740

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:
Bugs:

  • Miner constructor params were not being wrapped in init::ExecParams when calling init exec method
  • miner constructor was checking empty params (even though params are deserialized)
  • assign_proving_period_offset was panicking when writing to the address bytes (because it was attempting to write over the address bytes and would fail if the current length was not enough to write a BE u64 value) so I switched to using the buffer writing variant
  • Offset was not read and % from a unsigned integer, so values were off when calculating period offset

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit f309a28 into main Oct 13, 2020
@austinabell austinabell deleted the austin/actorfix branch October 13, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants