Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block validations and add chain export test #741

Merged
merged 27 commits into from
Oct 15, 2020
Merged

Fix block validations and add chain export test #741

merged 27 commits into from
Oct 15, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 11, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • e2e testing sync with chain export of first 40 tipsets (served through blocksync requests/responses)

Fixes:

  • Weight calculation was incorrect
  • Logic was incorrect on timestamp check
  • Validate miner was using current ts to validate, not the base ts
  • Ticket vrf was using header bytes to draw randomness, not miner address bytes
  • Message validation was very outdated (and broken logic)
  • Addresses resolved to key address for sig validation
  • miner_has_min_power was using wrong address for loading state
  • Blocksync response status code was incorrect

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell marked this pull request as ready for review October 13, 2020 18:27
@austinabell austinabell changed the title Chain export test Fix block validations and add chain export test Oct 13, 2020
ec2
ec2 approved these changes Oct 15, 2020
View reviewed changes
vm/actor/src/builtin/codes.rs
@@ -52,6 +52,11 @@ pub fn is_singleton_actor(code: &Cid) -> bool {
|| code == &*VERIFREG_ACTOR_CODE_ID
}

/// Returns true if the code belongs to a singleton actor.
pub fn is_account_actor(code: &Cid) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is wrong?

@austinabell austinabell merged commit 3e8fd6c into main Oct 15, 2020
@austinabell austinabell deleted the austin/exporttest branch October 15, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvermeulen timvermeulen timvermeulen approved these changes

@ec2 ec2 ec2 approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees
No one assigned
Labels
Blockchain Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinabell @timvermeulen @ec2