Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing 0s on bitfield serialization #746

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 14, 2020

Summary of changes
Changes introduced in this pull request:

  • Trailing 0 was being added to end of serialized bytes in an edge case
    • Also added a loop to remove any other 0 bytes because @timvermeulen suggested that it may be possible for this to happen

538/592

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell added Interop Interop with Lotus/specs-actors and testing Status: Merge Ready labels Oct 14, 2020
Co-authored-by: Tim Vermeulen <tvermeulen@me.com>
@austinabell austinabell merged commit 15e00e8 into main Oct 14, 2020
@austinabell austinabell deleted the austin/bfserfix branch October 14, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: Merge Ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants