Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockstore get gas charge #751

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Fix blockstore get gas charge #751

merged 5 commits into from
Oct 16, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 16, 2020

Summary of changes
Changes introduced in this pull request:

  • Gas charge for get used to be after the data was retrieved (because it included bytes written) which has changed. Thanks to how the extracted vectors are setup, this was caught (could have been a diff if an error was hit in the read)

577/592

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit d4de548 into main Oct 16, 2020
@austinabell austinabell deleted the austin/gasbsfix branch October 16, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants