Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow snapshot to be loaded from an http request and add progress #762

Closed
austinabell opened this issue Oct 19, 2020 · 2 comments · Fixed by #811
Closed

Allow snapshot to be loaded from an http request and add progress #762

austinabell opened this issue Oct 19, 2020 · 2 comments · Fixed by #811
Labels
Enhancement Priority: 4 - Low

Comments

@austinabell
Copy link
Contributor

Issue summary

Once #761 is in, would be very nice to allow for loading a snapshot from a url, as Lotus does it.

They also added in a progress bar for the snapshot import, and I think this would be a very nice UX to add. For this progress to show up well, it has to be before any of the async tasks are started, as the logger conflicts with the progress bar output (see fetch-params progress bar when requests are done async), but should be pretty straightforward

This issue is definitely low priority since it wouldn't add any new functionality.

Other information and links
@snaumov
Copy link
Contributor

snaumov commented Oct 30, 2020

I can look into it this week :)

@ec2
Copy link
Member

ec2 commented Oct 30, 2020

Just for more guidance, I made this PR for importing snapshots #789

snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
b07bbac
snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
74f1191
snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
8456cb5
@snaumov snaumov mentioned this issue Nov 5, 2020
Merged
snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
66f8ec3
snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
fa9b0bb
snaumov added a commit to snaumov/forest that referenced this issue Nov 5, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
128af58
snaumov added a commit to snaumov/forest that referenced this issue Nov 13, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
198465c
snaumov added a commit to snaumov/forest that referenced this issue Nov 18, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
2ba2953
snaumov added a commit to snaumov/forest that referenced this issue Nov 19, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (ChainSafe#762)
f276ad9
austinabell pushed a commit that referenced this issue Nov 19, 2020
@snaumov
Allow importing snapshot from URL + Progress bar (#762) (#811)
d6c9bf6 
* Allow importing snapshot from URL + Progress bar (#762)

* second interation

* rebasing, fixing linters

* generic write on FetchProgress

* addressing comments

* switching to TryFrom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Priority: 4 - Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow importing snapshot from URL + Progress bar (#762) snaumov/forest
4 participants
@amerameen @snaumov @ec2 @austinabell