Import snapshots and import chains #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
timvermeulen,
RajarupanSampanthan and
StaticallyTypedAnxiety
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
dutterbutter
suggested changes
Oct 26, 2020
austinabell
suggested changes
Oct 27, 2020
| @@ -60,6 +93,16 @@ pub(super) async fn start(config: Config) { | |||
| let mut db = RocksDb::new(config.data_dir + "/db"); | |||
| db.open().unwrap(); | |||
| let db = Arc::new(db); | |||
|
|
|||
| // Sync from snapshot | |||
There was a problem hiding this comment.
If I understand correctly we dont actually sync from snapshot rather we set the snapshot? Reason I mention this is because I dont think any sync logic is called in import_chain?
There was a problem hiding this comment.
Well, we populate our blockstore from the snapshot file. And furthermore, we can also recompute all the state if we import with --import-chain.
There was a problem hiding this comment.
Yeah if you're wondering why not full block valation, that is intended, it's just calculating intermediate states and validating those roots are correct (full block validation would be too slow when you want to trust the export)
austinabell
suggested changes
Oct 29, 2020
ec2
requested review from
dutterbutter and
austinabell
and removed request for
RajarupanSampanthan
dutterbutter
approved these changes
Oct 29, 2020
austinabell
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
--import-snapshot <filename>--import-chain <filename>Reference issue to close (if applicable)
Closes
#761
Other information and links