Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Amt iter mut guard #772

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Fix Amt iter mut guard #772

merged 2 commits into from
Oct 21, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 21, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Issue was is that all values were mutably dereferenced because generic function was the type within the guard

Thanks @ec2 for the heavy lifting

888/894

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 34759a8 into main Oct 21, 2020
@austinabell austinabell deleted the austin/amtiterfidx branch October 21, 2020 17:12
@timvermeulen
Copy link
Contributor

My bad, nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees
No one assigned
Labels
Status: Merge Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinabell @timvermeulen @ec2 @dutterbutter