Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync messages logic #778

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Fix sync messages logic #778

merged 3 commits into from
Oct 22, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Cleaned up FillTipset to remove need to clone, error response is the input tipset if it fails to load
  • Fixed logic in tipset bundle construction logic.
    • There was a lot of janky logic and weird indexing, so I just rewrote it (also avoids clones this way)

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 6fb284a into main Oct 22, 2020
@austinabell austinabell deleted the austin/fixmessagesync branch October 22, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants