Fix get_sectors_for_winning_post and cleanup #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
requested review from
StaticallyTypedAnxiety,
timvermeulen and
RajarupanSampanthan
dutterbutter
approved these changes
Oct 23, 2020
ec2
approved these changes
Oct 23, 2020
blockchain/blocks/src/header/mod.rs
Outdated
| @@ -236,7 +236,7 @@ impl BlockHeader { | |||
| pub fn beacon_entries(&self) -> &[BeaconEntry] { | |||
| &self.beacon_entries | |||
| } | |||
| /// Getter for window PoSt proof | |||
| /// Getter for winning PoSt proof | |||
| pub fn win_post_proof(&self) -> &[PoStProof] { | |||
There was a problem hiding this comment.
lmao i can see why this function name can cause confusion (winning vs window)
There was a problem hiding this comment.
I mean, there is nothing to confuse it with since there is no window post on the header, but I might as well change the function name too.
This was probably from before the PoSt proof split (iirc the name of it was window? If not idk why this comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
pubtag on this method so no one else goes through the same debugging I had toReference issue to close (if applicable)
Closes
Other information and links