Refactor types out of actors crate to prep for v2 upgrade #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
timvermeulen
approved these changes
Oct 27, 2020
austinabell
force-pushed
the
austin/acv2prep
branch
from
ca73259
to
756c6b6
Compare
ec2
approved these changes
Oct 28, 2020
vm/actor/src/lib.rs
Outdated
| @@ -30,16 +33,16 @@ lazy_static! { | |||
| /// Number of token units in an abstract "FIL" token. | |||
| /// The network works purely in the indivisible token amounts. | |||
| /// This constant converts to a fixed decimal with more human-friendly scale. | |||
| const TOKEN_PRECISION: u64 = 1_000_000_000_000_000_000; | |||
| pub const TOKEN_PRECISION: u64 = 1_000_000_000_000_000_000; | |||
There was a problem hiding this comment.
I know it isnt really part of this PR, but while youre at it, could you make this point to the one in types? (i think reward/types.rs also redefines this
There was a problem hiding this comment.
Yeah it was semi intentional since the go implementation redefines -- maybe they want the actors execution to not change even if the params outside changes? That was my thought, but it's not a good reason so I will share same
dutterbutter
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
DeadlineInfoReference issue to close (if applicable)
Closes #788
Other information and links