Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch store for randomness retrieval #793

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Switch store for randomness retrieval #793

merged 3 commits into from
Oct 28, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 28, 2020

Summary of changes
Changes introduced in this pull request:

  • So the randomness retrieval was using the runtime store, which is the gas charging blockstore lol
    • Side note following logic of gas charges, I don't see why this would be excluded from being charged, but I guess it doesn't matter to dig into that
  • Also changed a bigint conversion to be cleaner

That one was a lot to debug

Up to block 460 now though :)

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 5a8dfaa into main Oct 28, 2020
@austinabell austinabell deleted the austin/randstore branch October 28, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: Merge Ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants