Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Miner cron related things #795

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Fix Miner cron related things #795

merged 5 commits into from
Oct 29, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 28, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Fix miner cron related things
    • There was an infinite loop in our execution (partitions indexing)
    • Hamt bit width was default instead of actors width
    • Extra state read
    • Partitions updates never being added
    • Deadlines never being saved
  • I left a test in the Hamt, because it's not terrible to have (was debugging when I ran into bit width bug)

syncing to: 905

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell changed the title Fix Fix Miner cron related things Oct 28, 2020
@austinabell austinabell merged commit 54635c5 into main Oct 29, 2020
@austinabell austinabell deleted the austin/minercronfixes branch October 29, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvermeulen timvermeulen timvermeulen approved these changes

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees
No one assigned
Labels
Bug Status: Merge Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinabell @timvermeulen @ec2 @dutterbutter