Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize statediff and fix hamt bug #799

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Optimize statediff and fix hamt bug #799

merged 3 commits into from
Nov 2, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 31, 2020

Summary of changes
Changes introduced in this pull request:

  • Now the diff only shows the added, removed, or changed actor states instead of diffing the whole resolved and ordered (through BTreeMap) JSON state.
    • There was not a good reason to print out all other actors anyway, but this can be added if others want
    • It's basically instant now, and now usable on this much larger state
  • Bug in hamt was in the case of one of the child nodes being a link, if the other values are less than the max array length, it would be pulled up and the link would be removed

syncing to epoch: 1442

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 21d6108 into main Nov 2, 2020
@austinabell austinabell deleted the austin/sdupdate branch November 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants