Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gossipsub chain messages to MPool in the ChainSyncer instead of Libp2p Service #833

Merged
merged 6 commits into from
Nov 9, 2020
Merged

Add Gossipsub chain messages to MPool in the ChainSyncer instead of Libp2p Service #833

merged 6 commits into from
Nov 9, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Nov 9, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • I need this so i can resolve a circular dependency, because the MessagePool needs to import the forest_libp2p crate.

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 merged commit d74b34e into main Nov 9, 2020
@ec2 ec2 deleted the ec2/mpool-chainsyncer branch November 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvermeulen timvermeulen timvermeulen approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

Assignees
No one assigned
Labels
Blockchain Network Libp2p and PubSub stuff Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ec2 @timvermeulen @austinabell