Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc fixes and implementations #841

Merged
merged 32 commits into from
Nov 26, 2020
Merged

Rpc fixes and implementations #841

merged 32 commits into from
Nov 26, 2020

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • This implements various fixes for the rpc layer

Reference issue to close (if applicable)

Closes #830
Closes #800

Other information and links

austinabell
austinabell suggested changes Nov 10, 2020
View reviewed changes
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
vm/address/src/lib.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
vm/address/src/lib.rs Outdated Show resolved Hide resolved
blockchain/beacon/src/drand.rs Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
@StaticallyTypedAnxiety StaticallyTypedAnxiety mentioned this pull request Nov 24, 2020
Closed
austinabell
austinabell suggested changes Nov 24, 2020
View reviewed changes
key_management/src/keystore.rs Outdated Show resolved Hide resolved
key_management/src/keystore.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Show resolved Hide resolved
vm/address/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/wallet_api.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
crypto/src/signature.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
@ec2 ec2 added the RPC label Nov 25, 2020
austinabell
austinabell suggested changes Nov 25, 2020
View reviewed changes
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
crypto/src/signature.rs Show resolved Hide resolved
types/src/version.rs Outdated Show resolved Hide resolved
vm/address/src/lib.rs Outdated Show resolved Hide resolved
@austinabell
Copy link
Contributor

I just added a bunch of notes to index the things that should be looked into, @ec2 let me know which (if any) you'd like me to update. I don't want to step on your toes with the changes you're doing

@ec2 ec2 requested a review from austinabell November 25, 2020 21:30
austinabell
austinabell reviewed Nov 26, 2020
View reviewed changes
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Outdated Show resolved Hide resolved
types/src/version.rs Outdated Show resolved Hide resolved
austinabell
austinabell approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take approval with grain of salt because I was last to push to this branch

@ec2
Copy link
Member

ec2 commented Nov 26, 2020

take approval with grain of salt because I was last to push to this branch

Your changes LGTM

@ec2 ec2 merged commit 56b4961 into main Nov 26, 2020
@ec2 ec2 deleted the rpc-fixes-and-implementations branch November 26, 2020 16:29
austinabell added a commit that referenced this pull request Nov 29, 2020
@austinabell
Fix syncing regressions from #841
9acf2d3
austinabell added a commit that referenced this pull request Nov 29, 2020
@austinabell
Fix syncing regressions from #841
867bec1
@austinabell austinabell mentioned this pull request Nov 29, 2020
Merged
austinabell added a commit that referenced this pull request Nov 30, 2020
@austinabell
Fix syncing regressions from #841 (#873)
15c0e67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@ec2 ec2 Awaiting requested review from ec2

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
RPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GetNtwkVersion to State Manager MinerGetBaseInfo needed for Storage Miner
3 participants
@StaticallyTypedAnxiety @austinabell @ec2