Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with import and cleanup #844

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Fix bug with import and cleanup #844

merged 3 commits into from
Nov 11, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Fixes bug where if starting on a fresh data directory, importing a chain would fail during validations because the genesis was not initialized
  • Cleaned up code and setup import to be used outside of forest (I'm benchmarking and testing using an external bin to avoid compiling all of forest, only what I need)
  • Removed DatabaseService trait, very useless, no need to ever swap out database implementation at runtime, should be a build flag

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit c53a5b8 into main Nov 11, 2020
@austinabell austinabell deleted the austin/bench branch November 11, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants