Use upstream cid #850
Merged
Use upstream cid #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
reviewed
Nov 13, 2020
|
@austinabell what about this plan:
|
Sounds great to me, the PRs I would like to get in before retesting are #847 #849 and #851 and I will let you know when those come in. I do believe your changes should be good as is, as I did some testing of it, I just want to check a couple things first and be completely sure if you don't mind |
Instead of a custom implementation of cid, wrap the upstream version.
An assert was commented out during development and was forgotten to be commented in again.
The `DAG_PB` constant isn't really needed.
vmx
force-pushed
the
upgrade-rust-cid-06
branch
from
8ee7270
to
d05edcb
Compare
austinabell
reviewed
Nov 16, 2020
austinabell
approved these changes
Nov 17, 2020
ec2
approved these changes
Nov 17, 2020
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a custom implementation of cid, wrap the upstream version.
Summary of changes
Changes introduced in this pull request:
Other information and links
I removed the "default CID" case from the CID serializer as the old default CID won't work with rust-cid as it was an invalid CID.
This PR is intentionally using the rust-cid master branch and not a release as I would like to see if things would work with that version of rust-cid or if any changes would be nice/needed before I do a release (as this release is a huge breaking one, so it's the chance to break more things).
There is a
new_from_cbor()function which I made into a module's function instead of adding it to theCidimpl. The reason is that I wanted to keep theCida pure wrapper around the upstreamCidwithout additional methods. Though I'm happy to change that if requested.Feedback in welcome.