MessagePool Greedy Message Selection #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
austinabell,
dutterbutter and
timvermeulen
as code owners
…o ec2/mpool-selection
timvermeulen
approved these changes
Nov 20, 2020
austinabell
reviewed
Nov 20, 2020
| /// Like head_change, except it doesnt change the state of the MessagePool. | ||
| /// It simulates a head change call. | ||
| pub async fn run_head_change<T>( | ||
| api: &RwLock<T>, |
There was a problem hiding this comment.
Can definitely come in another PR, but it's really weird and probably really slow to have all interactions with the provider be behind a mutex, even for operations not relating to each other. It doesn't make sense that any of the functions require a mutable reference, so requiring an exclusive lock is definitely inefficient
austinabell
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #709
Other information and links