Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup mocking panic handling in vm #857

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • In go implementation, they catch any unexpected panic and wrap it with an exit code. We cannot match this (at least currently, but design might be flawed to allow us to safely do) so we just need to handle errors whenever assertions are expected to happen.
    • I've used the added function for the functions I know can and are hit, but there might be others. Until we find a way to match catching panics with other functionality maintained or they change the protocol we will have this vulnerability to our node crashing if anything in actors has a bug

I'll create an issue to detail the issue with actual panic catching. Syncs past 13154 point now

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 178d167 into main Nov 18, 2020
@austinabell austinabell deleted the austin/assertioninterop branch November 18, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants