Fork serde_bytes to disallow string and array deserialization #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
added
Status: Needs Review
Interop
austinabell
requested review from
dutterbutter,
ec2 and
timvermeulen
as code owners
dutterbutter
approved these changes
Nov 26, 2020
ec2
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Issue was that we allowed array deserialization (and
str), and the go implementation restricted to only bytes. Now this is symmetric.syncs past
36880now, https://filfox.info/en/message/bafy2bzaceabrez25khsfltuiireeng2p3avoniczz2scfsi54hykltoxjeslk?block=bafy2bzacealjcrqg27r4ny4mos37u3mk7cwxajrwnoi6djodr5d6aqdrlmigs was the message that was the issueReference issue to close (if applicable)
Closes
Other information and links