Implement Amt fuzzer #871
Merged
Implement Amt fuzzer #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
dutterbutter,
ec2 and
timvermeulen
as code owners
Merged
ec2
approved these changes
Nov 30, 2020
| @@ -22,6 +22,6 @@ criterion = "0.3.1" | |||
| ipld_blockstore = { path = "../blockstore", features = ["tracking"] } | |||
|
|
|||
| [[bench]] | |||
| name = "amt_beckmark" | |||
| name = "amt_benchmark" | |||
ec2
reviewed
Nov 30, 2020
ipld/amt/fuzz/Cargo.toml
Outdated
| [package] | ||
| name = "ipld_amt-fuzz" | ||
| version = "0.0.0" | ||
| authors = ["Automatically generated"] |
There was a problem hiding this comment.
It's just what cargo fuzz generates when creating a target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
cargo-fuzzfor the AmtWhat this does is fuzz test the usual operations on the Amt, and also performs the same operations on a map to ensure consistent functionality. This does two things: gives much larger confidence there will be no panics encountered with the Amt, and also gives more confidence of the functionality of the Amt in many different cases.
I ran the fuzzer with the go-interop feature on and off, and found no issues. I just wanted to fuzz the Amt and Hamt before cutting releases/ migrating to v2 actors
Reference issue to close (if applicable)
Closes
Other information and links