A bunch of fixes for the RPC #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
austinabell,
dutterbutter and
timvermeulen
as code owners
austinabell
approved these changes
Nov 30, 2020
| @@ -201,6 +201,9 @@ where | |||
|
|
|||
| /// Returns Tipset from key-value store from provided cids | |||
| pub async fn tipset_from_keys(&self, tsk: &TipsetKeys) -> Result<Arc<Tipset>, Error> { | |||
| if tsk.cids().is_empty() { | |||
| return Ok(self.heaviest_tipset().await.unwrap()); | |||
There was a problem hiding this comment.
Would be nice if this was handled, although I get this should never happen (we should maybe looking into changing this from being an Optional value and always initializing with a heaviest, initializing with genesis ts so we don't have to handle these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Refactor Gas API so that logic in those methods are reusable.
Adds gas_estimate_message_gas API call that allows for estimation of gas parameters like the premium, fee cap, etc...
Fixes some of the JSONRPC method names that have changed since initially implemented
Fixes Websocket Auth handling. Before a new PersistantKeyStore was created upon every connection and saved to
~./forest. This is not right, as we pass in the PersistantKeyStore via the RpcState.Adds message pool message selection to the RPC.
Fixes some methods in message pool RPC.
Fixes a bunch of methods in the state manager RPC.
Reference issue to close (if applicable)
Closes
Other information and links
Making this PR before more random fixes come in and PR blows up with too many changes in too many different places.
There is still some weird issue on when a message gets pushed to the message pool. I believe it has something to do with the VM execution though...