Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Miner Init Interop #882

Merged
merged 18 commits into from
Dec 10, 2020
Merged

Storage Miner Init Interop #882

merged 18 commits into from
Dec 10, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Dec 9, 2020

Summary of changes
This PR allows us to initialize a Lotus storage miner.
Changes introduced in this pull request:

  • Fixes to the state manager: Fix wait for message and tipset executed message
  • Adds the ability to receive and process JSONRPC messages concurrently
  • Adds SyncSubmitBlock method which accepts a block over JSONRPC which gets synced to by a sync worker
  • Adds some missing State API methods with the big one being MinerCreateBlock which assembles a block for the miner
  • Fixes wallet signing where the string being signed isnt converted to base64 before signing
  • Fixes some misc. JSONRPC method signatures

Notes:
Although this PR is IMO ready for review, there are some fixes that I would like the reviewer to give an opinion on:
Testing conditions for this PR are such that the Forest node is the only node on the network, thus it has no peers. Since it has no peers, the sync_workers sync method will be stuck in a loop. This results in newly mined blocks being submitted through SyncSubmitBlock to not be processed. Currently I have commented out this check for peer count. Wondering what yalls opinion is on this.

Reference issue to close (if applicable)

Closes #765, #766, #767

Other information and links

blockchain/blocks/src/lib.rs Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/chain_sync/src/sync.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/policy.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/policy.rs Outdated Show resolved Hide resolved
@ec2 ec2 requested a review from austinabell December 10, 2020 18:37
@ec2 ec2 merged commit aa44870 into main Dec 10, 2020
@ec2 ec2 deleted the ec2/storage-miner-init-interop branch December 10, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing Block Production: Miner can produce 1 block that gets sent to Forest over RPC and published
2 participants