-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage Miner Init Interop #882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
added
Status: Needs Review
Blockchain
Network
Libp2p and PubSub stuff
Storage Miner
RPC
labels
Dec 9, 2020
ec2
requested review from
austinabell,
dutterbutter and
timvermeulen
as code owners
December 9, 2020 07:00
austinabell
reviewed
Dec 9, 2020
austinabell
reviewed
Dec 9, 2020
austinabell
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR allows us to initialize a Lotus storage miner.
Changes introduced in this pull request:
Notes:
Although this PR is IMO ready for review, there are some fixes that I would like the reviewer to give an opinion on:
Testing conditions for this PR are such that the Forest node is the only node on the network, thus it has no peers. Since it has no peers, the sync_workers sync method will be stuck in a loop. This results in newly mined blocks being submitted through SyncSubmitBlock to not be processed. Currently I have commented out this check for peer count. Wondering what yalls opinion is on this.
Reference issue to close (if applicable)
Closes #765, #766, #767
Other information and links