Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coverage from CI until fixed #883

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Remove coverage from CI until fixed #883

merged 1 commit into from
Dec 10, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Been wasting CI resources, but I want to make this change to fix a few things:
    • New CI wasn't checking license anymore
    • Fix gitmodules https over git
    • README coverage label broken (will fix in Fix code coverage #860 or whatever PR fixes it when we have the time)
    • Use env variable for proofs cache

Reference issue to close (if applicable)

Closes

Other information and links

ec2
ec2 reviewed Dec 10, 2020
View reviewed changes
.circleci/config.yml
@@ -53,6 +53,7 @@ commands:
echo 'export CARGO_INCREMENTAL=0' >> $BASH_ENV
echo 'export CI_TIMEOUT="timeout 40m"' >> $BASH_ENV
echo 'export CC=gcc' >> $BASH_ENV
echo 'export FIL_PROOFS_PARAMETER_CACHE=$HOME/.proof-params' >> $BASH_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats wrong with the default path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the tmp directory, so this is more easily accessed and persisted (it's needed when running certain commands, but not immediately needed now in the CI). Just a good idea to set imo

@austinabell austinabell merged commit 8e821e0 into main Dec 10, 2020
@austinabell austinabell deleted the austin/rmcov branch December 10, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
Maintenance Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinabell @ec2