Update seal proof types and proofs api version #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
dutterbutter,
ec2 and
timvermeulen
as code owners
ec2
approved these changes
Dec 14, 2020
| @@ -14,6 +14,12 @@ pub enum RegisteredSealProof { | |||
| StackedDRG8MiBV1, | |||
| StackedDRG32GiBV1, | |||
| StackedDRG64GiBV1, | |||
|
|
|||
| StackedDRG2KiBV1P1, | |||
There was a problem hiding this comment.
Any clues as to what the P1 at the end stands for? Just curious
There was a problem hiding this comment.
I made that on our end, they have V1_1 but I didn't want to add underscores in the variant since it's against rust's conventions so I added P1 as in the (p)roofs version 1. Open to suggestions or if you think this should just be _1 to match exactly and ignore the lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Changes necessary for power actor v2 update
Reference issue to close (if applicable)
Closes
Other information and links