Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cfg flag to build Forest in Devnet mode #895

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Add a cfg flag to build Forest in Devnet mode #895

merged 4 commits into from
Dec 16, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Dec 16, 2020

Summary of changes
Changes introduced in this pull request:
On enabling the devnet flag,

  • Allows for 2k sectors
  • Sets the min consensus power to 2048

In draft because I need write access to the actor_v0 repo to add the flag on v0 actors. @austinabell

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell
Copy link
Contributor

Gave permissions. As for these changes, it would be nice if the deal minimum (MINIMUM_VERIFIED_DEAL_SIZE) and other parameters associated with the devnet are changed. Things like block delay and other parameters might be nice to also lower for testing, and we can consider changing the upgrade schedule too maybe?

@ec2
Copy link
Member Author

ec2 commented Dec 16, 2020

Cool, I can do the block delay and minimum verified deal size. The upgrade schedule is a little bit more tricky. I dont think it's worth adding that right now. When im doing storage miner testing, i actually have been disabling all the upgrades.

@ec2 ec2 marked this pull request as ready for review December 16, 2020 16:59
@@ -4,6 +4,7 @@
use fil_types::{RegisteredSealProof, StoragePower};

/// Returns the minimum storage power required for each seal proof types.
#[cfg(not(feature = "devnet"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, you probably want to just have the feature functionality within the scope of the function, to be sure that there will be no differences in the future, but this is totally fine for this case

@ec2 ec2 merged commit 88d1d46 into main Dec 16, 2020
@ec2 ec2 deleted the ec2/cfg-devnet branch December 16, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants