Update runtime for network version upgrades #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
dutterbutter,
ec2 and
timvermeulen
as code owners
austinabell
added
Spec Change
ec2
approved these changes
Dec 17, 2020
| &self.caller | ||
| } | ||
| fn receiver(&self) -> &Address { | ||
| // * Can't assert that receiver is an ID address here because it was not being done | ||
| // * pre NetworkVersion3. Can maybe add in assertion later |
There was a problem hiding this comment.
If this is part of the v2 actors and syncing with mainnet, shouldn't you just get that in now? Or is it a big effort that should be done in another PR?
There was a problem hiding this comment.
No like we can't do it at all, because it breaks in <v3. There is no possible way to do this without not supporting those versions
There was a problem hiding this comment.
it's one assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
There was some test vectors failing in paych actor, and wanted to make sure that I didn't miss anything in the update. Passes 1267/1294 now
Reference issue to close (if applicable)
Closes
Other information and links