Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Insecure Post-Validation #916

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Adding Insecure Post-Validation #916

merged 5 commits into from
Jan 7, 2021

Conversation

RajarupanSampanthan
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Adding Insecure post-validation

Command to run :
cargo run --manifest-path forest/Cargo.toml --features="insecure_post"

Reference issue to close (if applicable)

Closes #713

Other information and links

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Would you mind just making this the changes necessary and not formatting and reorganizing the imports? It's just inconsistent with the formatting of other cargo.toml files and hard to see what has changed

Otherwise lgtm!

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for @ec2 approval since he's working on relating things :)

@austinabell austinabell merged commit fa82654 into ChainSafe:main Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow insecure post validation
3 participants