Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup epoch time #92

Merged
merged 3 commits into from
Dec 11, 2019
Merged

cleanup epoch time #92

merged 3 commits into from
Dec 11, 2019

Conversation

GregTheGreek
Copy link
Member

Features

  • Switches to i64
  • Adds EpochTime
  • Minor cleanup

Closes #64

austinabell
austinabell suggested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be better

node/src/clock/mod.rs Outdated Show resolved Hide resolved
node/src/clock/mod.rs Outdated Show resolved Hide resolved
GregTheGreek and others added 2 commits December 10, 2019 16:38
@GregTheGreek @austinabell
Update node/src/clock/mod.rs
d30e51e 
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
@GregTheGreek
address nits
1d02b1a
ec2
ec2 requested changes Dec 11, 2019
View reviewed changes
node/src/clock/mod.rs Show resolved Hide resolved
@GregTheGreek GregTheGreek merged commit cb4576d into master Dec 11, 2019
@GregTheGreek GregTheGreek deleted the greg/clock/todo branch December 11, 2019 17:12
@austinabell austinabell mentioned this pull request Dec 11, 2019
Merged
vmx pushed a commit to dignifiedquire/forest that referenced this pull request Mar 19, 2020
@laser
handle corrupted or missing sector builder metadata on load (ChainSaf…
ae19187 
…e#92)

* fix(tests): tests which exercise panic conditions

* fix(snapshots): don't panic if snapshot cannot be loaded

* refactor(errors): better error messages

* ci(ignore): make test running optional b/c requires params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ChainEpoch type and epoch_at_time method
5 participants
@GregTheGreek @ec2 @austinabell @dutterbutter @ansermino