Change default address prefix to 'f' #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajarupanSampanthan
requested review from
austinabell,
dutterbutter and
ec2
as code owners
austinabell
reviewed
Jan 11, 2021
There was a problem hiding this comment.
Thanks for the PR, don't worry about that test case that's failing (the issue is just the inability to keep the network prefix when going to and from Cbor). Feel free to just #[ignore] the test case and I can follow this PR with a workaround :)
Edit: or if you'd like to change yourself, you can just remove the encoded bytes assertion on line 28 of block_header_ser.rs (checking cids are equal is sufficient)
austinabell
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #867
Other information and links