Fix ChainNotify RPC #924
Merged
Fix ChainNotify RPC #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
approved these changes
Jan 11, 2021
austinabell
reviewed
Jan 11, 2021
| @@ -967,20 +967,17 @@ where | |||
|
|
|||
| pub async fn sub_head_changes( | |||
| mut subscribed_head_change: Subscriber<HeadChange>, | |||
| heaviest_tipset: &Option<Arc<Tipset>>, | |||
| heaviest_tipset: &Arc<Tipset>, | |||
There was a problem hiding this comment.
also, does it need to be a reference if it can just be moved? it's cloned during the subscribe?
Doesn't really matter, but just mentioning. The clone might get optimized away anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links