Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header signing bytes cache bug #935

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Fix header signing bytes cache bug #935

merged 1 commit into from
Jan 18, 2021

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Fixes bug introduced in Update header caches and builder #930 where the marshalling is now using the cached bytes, which caused an issue with the header conversion to signing bytes, because it used the cached bytes including the signature encoded

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit a79a97a into main Jan 18, 2021
@austinabell austinabell deleted the austin/fixheadercache branch January 18, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinabell @ec2